[PATCH] drm/etnaviv: fix for 64bit seqno change

[Christian König]

The fence seqno is now 64bit, fixes build warning.

Signed-off-by: Christian König <***@amd.com>
---
drivers/gpu/drm/etnaviv/etnaviv_gem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
index 1fa74226db91..5c48915f492d 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_gem.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
@@ -449,7 +449,7 @@ static void etnaviv_gem_describe_fence(struct dma_fence *fence,
const char *type, struct seq_file *m)
{
if (!test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags))
- seq_printf(m, "\t%9s: %s %s seq %u\n",
+ seq_printf(m, "\t%9s: %s %s seq %llu\n",
type,
fence->ops->get_driver_name(fence),
fence->ops->get_timeline_name(fence),

[Alex Deucher]

On Fri, Dec 7, 2018 at 2:11 PM Christian König

Post by Christian König
The fence seqno is now 64bit, fixes build warning.
---
drivers/gpu/drm/etnaviv/etnaviv_gem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
index 1fa74226db91..5c48915f492d 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_gem.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
@@ -449,7 +449,7 @@ static void etnaviv_gem_describe_fence(struct dma_fence *fence,
const char *type, struct seq_file *m)
{
if (!test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags))
- seq_printf(m, "\t%9s: %s %s seq %u\n",
+ seq_printf(m, "\t%9s: %s %s seq %llu\n",
type,
fence->ops->get_driver_name(fence),
fence->ops->get_timeline_name(fence),
--
2.14.1
_______________________________________________
dri-devel mailing list
https://lists.freedesktop.org/mailman/listinfo/dri-devel

[kbuild test robot]

Hi Christian,

I love your patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on v4.20-rc5 next-20181207]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Christian-K-nig/drm-etnaviv-fix-for-64bit-seqno-change/20181208-062755
config: arm-allmodconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=arm

drivers/gpu/drm/etnaviv/etnaviv_gem.c:452:38: warning: format '%llu' expects argument of type 'long long unsigned int', but argument 6 has type 'unsigned int' [-Wformat=]

seq_printf(m, "\t%9s: %s %s seq %llu\n",
~~~^
%u
drivers/gpu/drm/etnaviv/etnaviv_gem.c:456:7:
fence->seqno);
~~~~~~~~~~~~

vim +452 drivers/gpu/drm/etnaviv/etnaviv_gem.c

446
447 #ifdef CONFIG_DEBUG_FS
448 static void etnaviv_gem_describe_fence(struct dma_fence *fence,
449 const char *type, struct seq_file *m)
450 {
451 if (!test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags))

452 seq_printf(m, "\t%9s: %s %s seq %llu\n",

453 type,
454 fence->ops->get_driver_name(fence),
455 fence->ops->get_timeline_name(fence),
456 fence->seqno);
457 }
458

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation

[Lucas Stach]

Post by Christian König
The fence seqno is now 64bit, fixes build warning.
---
 drivers/gpu/drm/etnaviv/etnaviv_gem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c
b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
index 1fa74226db91..5c48915f492d 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_gem.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_gem.c
@@ -449,7 +449,7 @@ static void etnaviv_gem_describe_fence(struct dma_fence *fence,
  const char *type, struct seq_file *m)
 {
  if (!test_bit(DMA_FENCE_FLAG_SIGNALED_BIT, &fence->flags))
- seq_printf(m, "\t%9s: %s %s seq %u\n",
+ seq_printf(m, "\t%9s: %s %s seq %llu\n",
     type,
     fence->ops->get_driver_name(fence),
     fence->ops->get_timeline_name(fence),