Discussion:
AMDGPU with 4.19.x kernel - cannot enable DPM
Chris Rankin
2018-11-23 00:22:44 UTC
Permalink
Hi,

I have recently tried to use dpm=1 with the amdgpu driver for the 4.19.x
kernel, but unfortunately the screen just went black. This is a regression
from the 4.18.x kernel.

I have attached the full dmesg log, but the relevant section look to be:

[ 8.958679] WARNING: CPU: 0 PID: 320 at drivers/gpu/drm/drm_mm.c:950
drm_mm_takedown+0x1f/0x30 [drm]
[ 9.010509] Code: f6 c3 48 8d 41 c0 eb bb 0f 1f 00 66 66 66 66 90 48 8b
47 38 48 83 c7 38 48 39 c7 75 01 c3 48 c7 c7 a0 68 26 c0 e8 6b 4d e8 d9
<0f> 0b c3 0f 1f 40 00 66 2e 0f 1f 84 00 00 00 00 00 66 66 66 66 90
[ 9.029395] RSP: 0018:ffffae0681e8f9e8 EFLAGS: 00010282
[ 9.034681] RAX: 0000000000000000 RBX: ffff91febbb9f900 RCX:
0000000000000000
[ 9.041875] RDX: ffff91fec3a1cf00 RSI: ffff91fec3a16868 RDI:
ffff91fec3a16868
[ 9.049068] RBP: ffff91feb92b29a0 R08: 0000000000000000 R09:
ffff91fb800bb480
[ 9.056260] R10: ffffffff9a4e7560 R11: ffffffff9b9b616d R12:
ffff91feb92b2980
[ 9.063454] R13: 0000000000000000 R14: 0000000000000170 R15:
ffff91feb938aee0
[ 9.070647] FS: 00007f71200ee180(0000) GS:ffff91fec3a00000(0000)
knlGS:0000000000000000
[ 9.078821] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 9.084625] CR2: 00007f8be0615020 CR3: 000000033b014000 CR4:
00000000000006f0

Cheers,
Chris
Alex Deucher
2018-11-23 20:25:07 UTC
Permalink
Hi,
I have recently tried to use dpm=1 with the amdgpu driver for the 4.19.x kernel, but unfortunately the screen just went black. This is a regression from the 4.18.x kernel.
[ 8.958679] WARNING: CPU: 0 PID: 320 at drivers/gpu/drm/drm_mm.c:950 drm_mm_takedown+0x1f/0x30 [drm]
[ 9.010509] Code: f6 c3 48 8d 41 c0 eb bb 0f 1f 00 66 66 66 66 90 48 8b 47 38 48 83 c7 38 48 39 c7 75 01 c3 48 c7 c7 a0 68 26 c0 e8 6b 4d e8 d9 <0f> 0b c3 0f 1f 40 00 66 2e 0f 1f 84 00 00 00 00 00 66 66 66 66 90
[ 9.029395] RSP: 0018:ffffae0681e8f9e8 EFLAGS: 00010282
[ 9.034681] RAX: 0000000000000000 RBX: ffff91febbb9f900 RCX: 0000000000000000
[ 9.041875] RDX: ffff91fec3a1cf00 RSI: ffff91fec3a16868 RDI: ffff91fec3a16868
[ 9.049068] RBP: ffff91feb92b29a0 R08: 0000000000000000 R09: ffff91fb800bb480
[ 9.056260] R10: ffffffff9a4e7560 R11: ffffffff9b9b616d R12: ffff91feb92b2980
[ 9.063454] R13: 0000000000000000 R14: 0000000000000170 R15: ffff91feb938aee0
[ 9.070647] FS: 00007f71200ee180(0000) GS:ffff91fec3a00000(0000) knlGS:0000000000000000
[ 9.078821] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 9.084625] CR2: 00007f8be0615020 CR3: 000000033b014000 CR4: 00000000000006f0
You may need this patch depending on your platform:
https://patchwork.freedesktop.org/patch/259364/

Alex
Cheers,
Chris
_______________________________________________
dri-devel mailing list
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Chris Rankin
2018-11-24 13:12:15 UTC
Permalink
Hi, thanks for the reply.

That patch doesn't solve my issue, although it does mean that the DRM layer
no longer tries to enable "gen 3" PCIE link speeds.
I have attached the dmesg output for a stock 4.19.4 kernel that also has
your patch applied.

Cheers,
Chris
Post by Chris Rankin
Post by Chris Rankin
Hi,
I have recently tried to use dpm=1 with the amdgpu driver for the 4.19.x
kernel, but unfortunately the screen just went black. This is a regression
from the 4.18.x kernel.
Post by Chris Rankin
[ 8.958679] WARNING: CPU: 0 PID: 320 at drivers/gpu/drm/drm_mm.c:950
drm_mm_takedown+0x1f/0x30 [drm]
Post by Chris Rankin
[ 9.010509] Code: f6 c3 48 8d 41 c0 eb bb 0f 1f 00 66 66 66 66 90 48
8b 47 38 48 83 c7 38 48 39 c7 75 01 c3 48 c7 c7 a0 68 26 c0 e8 6b 4d e8 d9
<0f> 0b c3 0f 1f 40 00 66 2e 0f 1f 84 00 00 00 00 00 66 66 66 66 90
Post by Chris Rankin
[ 9.029395] RSP: 0018:ffffae0681e8f9e8 EFLAGS: 00010282
0000000000000000
ffff91fec3a16868
ffff91fb800bb480
ffff91feb92b2980
ffff91feb938aee0
Post by Chris Rankin
[ 9.070647] FS: 00007f71200ee180(0000) GS:ffff91fec3a00000(0000)
knlGS:0000000000000000
Post by Chris Rankin
[ 9.078821] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
00000000000006f0
https://patchwork.freedesktop.org/patch/259364/
Alex
Post by Chris Rankin
Cheers,
Chris
_______________________________________________
dri-devel mailing list
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Chris Rankin
2018-12-06 13:38:16 UTC
Permalink
Hi,

I'm still unable to enable DPM with my R7 360, AMDGPU driver, Linux 4.19.7
kernel. Dmesg log is attached, showing that it is correctly using PCIE gen2
speeds.

Cheers,
Chris
Post by Chris Rankin
Hi, thanks for the reply.
That patch doesn't solve my issue, although it does mean that the DRM
layer no longer tries to enable "gen 3" PCIE link speeds.
I have attached the dmesg output for a stock 4.19.4 kernel that also has
your patch applied.
Cheers,
Chris
Post by Chris Rankin
Hi,
I have recently tried to use dpm=1 with the amdgpu driver for the
4.19.x kernel, but unfortunately the screen just went black. This is a
regression from the 4.18.x kernel.
Post by Chris Rankin
[ 8.958679] WARNING: CPU: 0 PID: 320 at drivers/gpu/drm/drm_mm.c:950
drm_mm_takedown+0x1f/0x30 [drm]
Post by Chris Rankin
[ 9.010509] Code: f6 c3 48 8d 41 c0 eb bb 0f 1f 00 66 66 66 66 90 48
8b 47 38 48 83 c7 38 48 39 c7 75 01 c3 48 c7 c7 a0 68 26 c0 e8 6b 4d e8 d9
<0f> 0b c3 0f 1f 40 00 66 2e 0f 1f 84 00 00 00 00 00 66 66 66 66 90
Post by Chris Rankin
[ 9.029395] RSP: 0018:ffffae0681e8f9e8 EFLAGS: 00010282
0000000000000000
ffff91fec3a16868
ffff91fb800bb480
ffff91feb92b2980
ffff91feb938aee0
Post by Chris Rankin
[ 9.070647] FS: 00007f71200ee180(0000) GS:ffff91fec3a00000(0000)
knlGS:0000000000000000
Post by Chris Rankin
[ 9.078821] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
00000000000006f0
https://patchwork.freedesktop.org/patch/259364/
Alex
Post by Chris Rankin
Cheers,
Chris
_______________________________________________
dri-devel mailing list
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Alex Deucher
2018-12-06 15:47:16 UTC
Permalink
I can't reproduce this. Can you bisect?

Alex
Hi,
I'm still unable to enable DPM with my R7 360, AMDGPU driver, Linux 4.19.7 kernel. Dmesg log is attached, showing that it is correctly using PCIE gen2 speeds.
Cheers,
Chris
Post by Chris Rankin
Hi, thanks for the reply.
That patch doesn't solve my issue, although it does mean that the DRM layer no longer tries to enable "gen 3" PCIE link speeds.
I have attached the dmesg output for a stock 4.19.4 kernel that also has your patch applied.
Cheers,
Chris
Post by Alex Deucher
Hi,
I have recently tried to use dpm=1 with the amdgpu driver for the 4.19.x kernel, but unfortunately the screen just went black. This is a regression from the 4.18.x kernel.
[ 8.958679] WARNING: CPU: 0 PID: 320 at drivers/gpu/drm/drm_mm.c:950 drm_mm_takedown+0x1f/0x30 [drm]
[ 9.010509] Code: f6 c3 48 8d 41 c0 eb bb 0f 1f 00 66 66 66 66 90 48 8b 47 38 48 83 c7 38 48 39 c7 75 01 c3 48 c7 c7 a0 68 26 c0 e8 6b 4d e8 d9 <0f> 0b c3 0f 1f 40 00 66 2e 0f 1f 84 00 00 00 00 00 66 66 66 66 90
[ 9.029395] RSP: 0018:ffffae0681e8f9e8 EFLAGS: 00010282
[ 9.034681] RAX: 0000000000000000 RBX: ffff91febbb9f900 RCX: 0000000000000000
[ 9.041875] RDX: ffff91fec3a1cf00 RSI: ffff91fec3a16868 RDI: ffff91fec3a16868
[ 9.049068] RBP: ffff91feb92b29a0 R08: 0000000000000000 R09: ffff91fb800bb480
[ 9.056260] R10: ffffffff9a4e7560 R11: ffffffff9b9b616d R12: ffff91feb92b2980
[ 9.063454] R13: 0000000000000000 R14: 0000000000000170 R15: ffff91feb938aee0
[ 9.070647] FS: 00007f71200ee180(0000) GS:ffff91fec3a00000(0000) knlGS:0000000000000000
[ 9.078821] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 9.084625] CR2: 00007f8be0615020 CR3: 000000033b014000 CR4: 00000000000006f0
https://patchwork.freedesktop.org/patch/259364/
Alex
Cheers,
Chris
_______________________________________________
dri-devel mailing list
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Alex Deucher
2018-12-06 15:53:07 UTC
Permalink
Does it work without amdgpu.dpm=1 on your kernel command line? You
don't need to specify it, it;s enabled by default. The default dpm
implementation changed so specifying dpm=1 will change the dpm
implementation used by the driver.

Alex
Post by Alex Deucher
I can't reproduce this. Can you bisect?
Alex
Hi,
I'm still unable to enable DPM with my R7 360, AMDGPU driver, Linux 4.19.7 kernel. Dmesg log is attached, showing that it is correctly using PCIE gen2 speeds.
Cheers,
Chris
Post by Chris Rankin
Hi, thanks for the reply.
That patch doesn't solve my issue, although it does mean that the DRM layer no longer tries to enable "gen 3" PCIE link speeds.
I have attached the dmesg output for a stock 4.19.4 kernel that also has your patch applied.
Cheers,
Chris
Post by Alex Deucher
Hi,
I have recently tried to use dpm=1 with the amdgpu driver for the 4.19.x kernel, but unfortunately the screen just went black. This is a regression from the 4.18.x kernel.
[ 8.958679] WARNING: CPU: 0 PID: 320 at drivers/gpu/drm/drm_mm.c:950 drm_mm_takedown+0x1f/0x30 [drm]
[ 9.010509] Code: f6 c3 48 8d 41 c0 eb bb 0f 1f 00 66 66 66 66 90 48 8b 47 38 48 83 c7 38 48 39 c7 75 01 c3 48 c7 c7 a0 68 26 c0 e8 6b 4d e8 d9 <0f> 0b c3 0f 1f 40 00 66 2e 0f 1f 84 00 00 00 00 00 66 66 66 66 90
[ 9.029395] RSP: 0018:ffffae0681e8f9e8 EFLAGS: 00010282
[ 9.034681] RAX: 0000000000000000 RBX: ffff91febbb9f900 RCX: 0000000000000000
[ 9.041875] RDX: ffff91fec3a1cf00 RSI: ffff91fec3a16868 RDI: ffff91fec3a16868
[ 9.049068] RBP: ffff91feb92b29a0 R08: 0000000000000000 R09: ffff91fb800bb480
[ 9.056260] R10: ffffffff9a4e7560 R11: ffffffff9b9b616d R12: ffff91feb92b2980
[ 9.063454] R13: 0000000000000000 R14: 0000000000000170 R15: ffff91feb938aee0
[ 9.070647] FS: 00007f71200ee180(0000) GS:ffff91fec3a00000(0000) knlGS:0000000000000000
[ 9.078821] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 9.084625] CR2: 00007f8be0615020 CR3: 000000033b014000 CR4: 00000000000006f0
https://patchwork.freedesktop.org/patch/259364/
Alex
Cheers,
Chris
_______________________________________________
dri-devel mailing list
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Chris Rankin
2018-12-06 15:58:46 UTC
Permalink
Yes, all 4.19.x kernels have been fine without the amdgpu.dpm=1 kernel
parameter. In fact, this is how I am running my kernel right now. With the
4.18.x series I did specify amdgpu.dpm=1 explicitly on the GRUB2 command
line, and I inherited this setting when I migrated to 4.19.
Post by Alex Deucher
Does it work without amdgpu.dpm=1 on your kernel command line? You
don't need to specify it, it;s enabled by default. The default dpm
implementation changed so specifying dpm=1 will change the dpm
implementation used by the driver.
Alex
Post by Alex Deucher
I can't reproduce this. Can you bisect?
Alex
Post by Chris Rankin
Hi,
I'm still unable to enable DPM with my R7 360, AMDGPU driver, Linux
4.19.7 kernel. Dmesg log is attached, showing that it is correctly using
PCIE gen2 speeds.
Post by Alex Deucher
Post by Chris Rankin
Cheers,
Chris
Post by Chris Rankin
Hi, thanks for the reply.
That patch doesn't solve my issue, although it does mean that the DRM
layer no longer tries to enable "gen 3" PCIE link speeds.
Post by Alex Deucher
Post by Chris Rankin
Post by Chris Rankin
I have attached the dmesg output for a stock 4.19.4 kernel that also
has your patch applied.
Post by Alex Deucher
Post by Chris Rankin
Post by Chris Rankin
Cheers,
Chris
Post by Alex Deucher
Post by Chris Rankin
Hi,
I have recently tried to use dpm=1 with the amdgpu driver for the
4.19.x kernel, but unfortunately the screen just went black. This is a
regression from the 4.18.x kernel.
Post by Alex Deucher
Post by Chris Rankin
Post by Chris Rankin
Post by Alex Deucher
Post by Chris Rankin
I have attached the full dmesg log, but the relevant section look
[ 8.958679] WARNING: CPU: 0 PID: 320 at
drivers/gpu/drm/drm_mm.c:950 drm_mm_takedown+0x1f/0x30 [drm]
Post by Alex Deucher
Post by Chris Rankin
Post by Chris Rankin
Post by Alex Deucher
Post by Chris Rankin
[ 9.010509] Code: f6 c3 48 8d 41 c0 eb bb 0f 1f 00 66 66 66 66
90 48 8b 47 38 48 83 c7 38 48 39 c7 75 01 c3 48 c7 c7 a0 68 26 c0 e8 6b 4d
e8 d9 <0f> 0b c3 0f 1f 40 00 66 2e 0f 1f 84 00 00 00 00 00 66 66 66 66 90
Post by Alex Deucher
Post by Chris Rankin
Post by Chris Rankin
Post by Alex Deucher
Post by Chris Rankin
[ 9.029395] RSP: 0018:ffffae0681e8f9e8 EFLAGS: 00010282
0000000000000000
ffff91fec3a16868
ffff91fb800bb480
ffff91feb92b2980
ffff91feb938aee0
Post by Alex Deucher
Post by Chris Rankin
Post by Chris Rankin
Post by Alex Deucher
Post by Chris Rankin
[ 9.070647] FS: 00007f71200ee180(0000)
GS:ffff91fec3a00000(0000) knlGS:0000000000000000
Post by Alex Deucher
Post by Chris Rankin
Post by Chris Rankin
Post by Alex Deucher
Post by Chris Rankin
[ 9.078821] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
00000000000006f0
Post by Alex Deucher
Post by Chris Rankin
Post by Chris Rankin
Post by Alex Deucher
https://patchwork.freedesktop.org/patch/259364/
Alex
Post by Chris Rankin
Cheers,
Chris
_______________________________________________
dri-devel mailing list
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Alex Deucher
2018-12-06 16:09:06 UTC
Permalink
Then you should be fine to remove it.

Alex
Yes, all 4.19.x kernels have been fine without the amdgpu.dpm=1 kernel parameter. In fact, this is how I am running my kernel right now. With the 4.18.x series I did specify amdgpu.dpm=1 explicitly on the GRUB2 command line, and I inherited this setting when I migrated to 4.19.
Post by Alex Deucher
Does it work without amdgpu.dpm=1 on your kernel command line? You
don't need to specify it, it;s enabled by default. The default dpm
implementation changed so specifying dpm=1 will change the dpm
implementation used by the driver.
Alex
Post by Alex Deucher
I can't reproduce this. Can you bisect?
Alex
Hi,
I'm still unable to enable DPM with my R7 360, AMDGPU driver, Linux 4.19.7 kernel. Dmesg log is attached, showing that it is correctly using PCIE gen2 speeds.
Cheers,
Chris
Post by Chris Rankin
Hi, thanks for the reply.
That patch doesn't solve my issue, although it does mean that the DRM layer no longer tries to enable "gen 3" PCIE link speeds.
I have attached the dmesg output for a stock 4.19.4 kernel that also has your patch applied.
Cheers,
Chris
Post by Alex Deucher
Hi,
I have recently tried to use dpm=1 with the amdgpu driver for the 4.19.x kernel, but unfortunately the screen just went black. This is a regression from the 4.18.x kernel.
[ 8.958679] WARNING: CPU: 0 PID: 320 at drivers/gpu/drm/drm_mm.c:950 drm_mm_takedown+0x1f/0x30 [drm]
[ 9.010509] Code: f6 c3 48 8d 41 c0 eb bb 0f 1f 00 66 66 66 66 90 48 8b 47 38 48 83 c7 38 48 39 c7 75 01 c3 48 c7 c7 a0 68 26 c0 e8 6b 4d e8 d9 <0f> 0b c3 0f 1f 40 00 66 2e 0f 1f 84 00 00 00 00 00 66 66 66 66 90
[ 9.029395] RSP: 0018:ffffae0681e8f9e8 EFLAGS: 00010282
[ 9.034681] RAX: 0000000000000000 RBX: ffff91febbb9f900 RCX: 0000000000000000
[ 9.041875] RDX: ffff91fec3a1cf00 RSI: ffff91fec3a16868 RDI: ffff91fec3a16868
[ 9.049068] RBP: ffff91feb92b29a0 R08: 0000000000000000 R09: ffff91fb800bb480
[ 9.056260] R10: ffffffff9a4e7560 R11: ffffffff9b9b616d R12: ffff91feb92b2980
[ 9.063454] R13: 0000000000000000 R14: 0000000000000170 R15: ffff91feb938aee0
[ 9.070647] FS: 00007f71200ee180(0000) GS:ffff91fec3a00000(0000) knlGS:0000000000000000
[ 9.078821] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 9.084625] CR2: 00007f8be0615020 CR3: 000000033b014000 CR4: 00000000000006f0
https://patchwork.freedesktop.org/patch/259364/
Alex
Cheers,
Chris
_______________________________________________
dri-devel mailing list
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Chris Rankin
2018-12-06 16:12:42 UTC
Permalink
OK, thanks. Although for reference, if DPM is now enabled by default I
would have expected amdgpu.dpm=1 to be a no-op rather than cause a black
screen and an oops... ;-).

Cheers,
Chris
Post by Alex Deucher
Then you should be fine to remove it.
Alex
Post by Chris Rankin
Yes, all 4.19.x kernels have been fine without the amdgpu.dpm=1 kernel
parameter. In fact, this is how I am running my kernel right now. With the
4.18.x series I did specify amdgpu.dpm=1 explicitly on the GRUB2 command
line, and I inherited this setting when I migrated to 4.19.
Post by Chris Rankin
Post by Alex Deucher
Does it work without amdgpu.dpm=1 on your kernel command line? You
don't need to specify it, it;s enabled by default. The default dpm
implementation changed so specifying dpm=1 will change the dpm
implementation used by the driver.
Alex
Post by Alex Deucher
I can't reproduce this. Can you bisect?
Alex
Post by Chris Rankin
Hi,
I'm still unable to enable DPM with my R7 360, AMDGPU driver, Linux
4.19.7 kernel. Dmesg log is attached, showing that it is correctly using
PCIE gen2 speeds.
Post by Chris Rankin
Post by Alex Deucher
Post by Alex Deucher
Post by Chris Rankin
Cheers,
Chris
Post by Chris Rankin
Hi, thanks for the reply.
That patch doesn't solve my issue, although it does mean that the
DRM layer no longer tries to enable "gen 3" PCIE link speeds.
Post by Chris Rankin
Post by Alex Deucher
Post by Alex Deucher
Post by Chris Rankin
Post by Chris Rankin
I have attached the dmesg output for a stock 4.19.4 kernel that
also has your patch applied.
Post by Chris Rankin
Post by Alex Deucher
Post by Alex Deucher
Post by Chris Rankin
Post by Chris Rankin
Cheers,
Chris
Post by Alex Deucher
Post by Chris Rankin
Hi,
I have recently tried to use dpm=1 with the amdgpu driver for
the 4.19.x kernel, but unfortunately the screen just went black. This is a
regression from the 4.18.x kernel.
Post by Chris Rankin
Post by Alex Deucher
Post by Alex Deucher
Post by Chris Rankin
Post by Chris Rankin
Post by Alex Deucher
Post by Chris Rankin
I have attached the full dmesg log, but the relevant section
[ 8.958679] WARNING: CPU: 0 PID: 320 at
drivers/gpu/drm/drm_mm.c:950 drm_mm_takedown+0x1f/0x30 [drm]
Post by Chris Rankin
Post by Alex Deucher
Post by Alex Deucher
Post by Chris Rankin
Post by Chris Rankin
Post by Alex Deucher
Post by Chris Rankin
[ 9.010509] Code: f6 c3 48 8d 41 c0 eb bb 0f 1f 00 66 66 66
66 90 48 8b 47 38 48 83 c7 38 48 39 c7 75 01 c3 48 c7 c7 a0 68 26 c0 e8 6b
4d e8 d9 <0f> 0b c3 0f 1f 40 00 66 2e 0f 1f 84 00 00 00 00 00 66 66 66 66 90
Post by Chris Rankin
Post by Alex Deucher
Post by Alex Deucher
Post by Chris Rankin
Post by Chris Rankin
Post by Alex Deucher
Post by Chris Rankin
[ 9.029395] RSP: 0018:ffffae0681e8f9e8 EFLAGS: 00010282
0000000000000000
ffff91fec3a16868
ffff91fb800bb480
ffff91feb92b2980
ffff91feb938aee0
Post by Chris Rankin
Post by Alex Deucher
Post by Alex Deucher
Post by Chris Rankin
Post by Chris Rankin
Post by Alex Deucher
Post by Chris Rankin
[ 9.070647] FS: 00007f71200ee180(0000)
GS:ffff91fec3a00000(0000) knlGS:0000000000000000
Post by Chris Rankin
Post by Alex Deucher
Post by Alex Deucher
Post by Chris Rankin
Post by Chris Rankin
Post by Alex Deucher
Post by Chris Rankin
[ 9.078821] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
00000000000006f0
Post by Chris Rankin
Post by Alex Deucher
Post by Alex Deucher
Post by Chris Rankin
Post by Chris Rankin
Post by Alex Deucher
https://patchwork.freedesktop.org/patch/259364/
Alex
Post by Chris Rankin
Cheers,
Chris
_______________________________________________
dri-devel mailing list
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Alex Deucher
2018-12-06 16:16:46 UTC
Permalink
the default is -1 (auto). Power management has always been enabled by
default on CI. the option is mainly there to disable power management
(amdgpu.dpm=0). Since there are two implementations for CI (the older
one ported from radeon and the newer powerplay one), explicitly
setting it to 1 was used to select between the two implementations for
testing purposes. The default implementation changed.

Alex
OK, thanks. Although for reference, if DPM is now enabled by default I would have expected amdgpu.dpm=1 to be a no-op rather than cause a black screen and an oops... ;-).
Cheers,
Chris
Post by Alex Deucher
Then you should be fine to remove it.
Alex
Yes, all 4.19.x kernels have been fine without the amdgpu.dpm=1 kernel parameter. In fact, this is how I am running my kernel right now. With the 4.18.x series I did specify amdgpu.dpm=1 explicitly on the GRUB2 command line, and I inherited this setting when I migrated to 4.19.
Post by Alex Deucher
Does it work without amdgpu.dpm=1 on your kernel command line? You
don't need to specify it, it;s enabled by default. The default dpm
implementation changed so specifying dpm=1 will change the dpm
implementation used by the driver.
Alex
Post by Alex Deucher
I can't reproduce this. Can you bisect?
Alex
Hi,
I'm still unable to enable DPM with my R7 360, AMDGPU driver, Linux 4.19.7 kernel. Dmesg log is attached, showing that it is correctly using PCIE gen2 speeds.
Cheers,
Chris
Post by Chris Rankin
Hi, thanks for the reply.
That patch doesn't solve my issue, although it does mean that the DRM layer no longer tries to enable "gen 3" PCIE link speeds.
I have attached the dmesg output for a stock 4.19.4 kernel that also has your patch applied.
Cheers,
Chris
Post by Alex Deucher
Hi,
I have recently tried to use dpm=1 with the amdgpu driver for the 4.19.x kernel, but unfortunately the screen just went black. This is a regression from the 4.18.x kernel.
[ 8.958679] WARNING: CPU: 0 PID: 320 at drivers/gpu/drm/drm_mm.c:950 drm_mm_takedown+0x1f/0x30 [drm]
[ 9.010509] Code: f6 c3 48 8d 41 c0 eb bb 0f 1f 00 66 66 66 66 90 48 8b 47 38 48 83 c7 38 48 39 c7 75 01 c3 48 c7 c7 a0 68 26 c0 e8 6b 4d e8 d9 <0f> 0b c3 0f 1f 40 00 66 2e 0f 1f 84 00 00 00 00 00 66 66 66 66 90
[ 9.029395] RSP: 0018:ffffae0681e8f9e8 EFLAGS: 00010282
[ 9.034681] RAX: 0000000000000000 RBX: ffff91febbb9f900 RCX: 0000000000000000
[ 9.041875] RDX: ffff91fec3a1cf00 RSI: ffff91fec3a16868 RDI: ffff91fec3a16868
[ 9.049068] RBP: ffff91feb92b29a0 R08: 0000000000000000 R09: ffff91fb800bb480
[ 9.056260] R10: ffffffff9a4e7560 R11: ffffffff9b9b616d R12: ffff91feb92b2980
[ 9.063454] R13: 0000000000000000 R14: 0000000000000170 R15: ffff91feb938aee0
[ 9.070647] FS: 00007f71200ee180(0000) GS:ffff91fec3a00000(0000) knlGS:0000000000000000
[ 9.078821] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 9.084625] CR2: 00007f8be0615020 CR3: 000000033b014000 CR4: 00000000000006f0
https://patchwork.freedesktop.org/patch/259364/
Alex
Cheers,
Chris
_______________________________________________
dri-devel mailing list
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Chris Rankin
2018-12-06 15:54:52 UTC
Permalink
Hi,

No, I can't bisect really. I've always compiled my kernels from a source
tar-ball. However, I have attached my .config in case it's useful.

Cheers,
Chris
Post by Alex Deucher
I can't reproduce this. Can you bisect?
Alex
Post by Chris Rankin
Hi,
I'm still unable to enable DPM with my R7 360, AMDGPU driver, Linux
4.19.7 kernel. Dmesg log is attached, showing that it is correctly using
PCIE gen2 speeds.
Post by Chris Rankin
Cheers,
Chris
Post by Chris Rankin
Hi, thanks for the reply.
That patch doesn't solve my issue, although it does mean that the DRM
layer no longer tries to enable "gen 3" PCIE link speeds.
Post by Chris Rankin
Post by Chris Rankin
I have attached the dmesg output for a stock 4.19.4 kernel that also
has your patch applied.
Post by Chris Rankin
Post by Chris Rankin
Cheers,
Chris
Post by Alex Deucher
Post by Chris Rankin
Hi,
I have recently tried to use dpm=1 with the amdgpu driver for the
4.19.x kernel, but unfortunately the screen just went black. This is a
regression from the 4.18.x kernel.
Post by Chris Rankin
Post by Chris Rankin
Post by Alex Deucher
Post by Chris Rankin
I have attached the full dmesg log, but the relevant section look to
[ 8.958679] WARNING: CPU: 0 PID: 320 at
drivers/gpu/drm/drm_mm.c:950 drm_mm_takedown+0x1f/0x30 [drm]
Post by Chris Rankin
Post by Chris Rankin
Post by Alex Deucher
Post by Chris Rankin
[ 9.010509] Code: f6 c3 48 8d 41 c0 eb bb 0f 1f 00 66 66 66 66 90
48 8b 47 38 48 83 c7 38 48 39 c7 75 01 c3 48 c7 c7 a0 68 26 c0 e8 6b 4d e8
d9 <0f> 0b c3 0f 1f 40 00 66 2e 0f 1f 84 00 00 00 00 00 66 66 66 66 90
Post by Chris Rankin
Post by Chris Rankin
Post by Alex Deucher
Post by Chris Rankin
[ 9.029395] RSP: 0018:ffffae0681e8f9e8 EFLAGS: 00010282
0000000000000000
ffff91fec3a16868
ffff91fb800bb480
ffff91feb92b2980
ffff91feb938aee0
Post by Chris Rankin
Post by Chris Rankin
Post by Alex Deucher
Post by Chris Rankin
[ 9.070647] FS: 00007f71200ee180(0000) GS:ffff91fec3a00000(0000)
knlGS:0000000000000000
Post by Chris Rankin
Post by Chris Rankin
Post by Alex Deucher
Post by Chris Rankin
[ 9.078821] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
00000000000006f0
Post by Chris Rankin
Post by Chris Rankin
Post by Alex Deucher
https://patchwork.freedesktop.org/patch/259364/
Alex
Post by Chris Rankin
Cheers,
Chris
_______________________________________________
dri-devel mailing list
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Loading...